Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: add SocketAddress.parse #56076

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

net: add SocketAddress.parse #56076

wants to merge 1 commit into from
+182 −100

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 29, 2024

Adds a new net.SocketAddress.parse(...) API.

const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Nov 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@lpinca lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 29, 2024
mcollina
mcollina approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell
net: add SocketAddress.parse
c79ac3b 
Adds a new `net.SocketAddress.parse(...)` API.

```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address);  // 123.123.123.123
console.log(addr.port); 1234
```
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63782/

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 29, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (4efb7ae) to head (c79ac3b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56076      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files         656      656              
  Lines      188988   189020      +32     
  Branches    35988    35993       +5     
==========================================
+ Hits       166302   166364      +62     
+ Misses      15848    15829      -19     
+ Partials     6838     6827      -11
Files with missing lines Coverage Δ
lib/internal/socketaddress.js 98.98% <100.00%> (+0.19%) ⬆️

... and 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@mcollina mcollina mcollina approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @mcollina @anonrig @lpinca