src: add missing qualifiers to env.cc #56062
Open
+27
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56062 +/- ##
==========================================
- Coverage 88.00% 87.99% -0.01%
==========================================
Files 656 656
Lines 188988 188985 -3
Branches 35992 35985 -7
==========================================
- Hits 166315 166299 -16
- Misses 15838 15846 +8
- Partials 6835 6840 +5
|
legendecas
reviewed
Nov 29, 2024
anonrig
force-pushed
the
yagiz/refactor-env-cc
branch
from
0f34ae2
to
1ead09b
Compare
jasnell
approved these changes
Nov 29, 2024
legendecas
approved these changes
Nov 29, 2024
anonrig
added
author ready
RafaelGSS
approved these changes
Nov 29, 2024
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56062 ✔ Done loading data for nodejs/node/pull/56062 ----------------------------------- PR info ------------------------------------ Title src: add missing qualifiers to env.cc (#56062) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:yagiz/refactor-env-cc -> nodejs:main Labels c++, author ready, needs-ci Commits 1 - src: add missing qualifiers to env.cc Committers 1 - Yagiz Nizipli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 28 Nov 2024 18:32:31 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56062#pullrequestreview-2470502104 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/56062#pullrequestreview-2470517275 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56062#pullrequestreview-2470595044 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-11-30T12:24:38Z: https://ci.nodejs.org/job/node-test-pull-request/63814/ - Querying data for job/node-test-pull-request/63814/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12098660097 |
mertcanaltin
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several missing
constqualifiers and replacesstd::vectorusage withv8::LocalVector<Value>for a function used for testing.FYI:
v8::LocalVectoris recommended to be used by the V8 team when storing them on heap. Ex: https://groups.google.com/g/v8-reviews/c/gM-dP-mASPI?pli=1