Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: allow napi_delete_reference in basic finalizers #55620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

node-api: allow napi_delete_reference in basic finalizers #55620

wants to merge 2 commits into from

Commits on Oct 31, 2024

  1. node-api: allow napi_delete_reference in finalizers 

    `napi_delete_reference` must be called immediately for a
`napi_reference` returned from `napi_wrap` in the corresponding
finalizer, in order to clean up the `napi_reference` timely.

`napi_delete_reference` is safe to be invoked during GC.
    @legendecas
    legendecas committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    139989e View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. fixup! node-api: allow napi_delete_reference in finalizers

    @legendecas
    legendecas committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    551a7ae View commit details
    Browse the repository at this point in the history