-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detecting step editor unmount #136
Comments
Hello @tskomudek, basically you can always save the latest value in the step like: <input type="text" ... onChange={e => setProperty('x', e.value)} /> So in the definition you will have allways the latest changes. If you have a save step between changing values and applying them, then you can create a hidden property in the step, such as <input type="text" ... onChange={e => setProperty('deltaX', e.value)} /> During saving changes you need to move values to a final property (deltaX => x). |
@tskomudek have you resolved the problem? |
Not really. Thx |
It looks like you need a Maybe a temporary solution would be to use the isSelectable: (step) => {
if (hasUnsavedChanges()) return window.confirm('You have unsaved data in the editor...');
// ...
} |
@ShraddhaFutrey it looks like the parent layers have not set any height constraints. The designer doesn't stretch parents, it adjusts to available space. You can check this theory by setting CSS: .sqd-designer {height: 900px;} BTW: please don't add comments to not related threads. |
Hi Bart, the isSelectable callback would help partially, but it doesn´t cover when the user just clicks into the canvas and the root editor appears or the user drags a new step from the toolbox. Thanks |
@tskomudek yes, this feature is planned but with a low priority. If you need this feature faster you can request it under the consulting service. |
Hi Bart,
when using a custom step editor in the react designer, i have the problem to loose the
current changes in the form when the user accidentally clicks into the editor space
and the stepeditor component gets unmounted.
I remember you wrote somewhere that this is currently not possible in the react version,
but do you have an idea how to work around this ?
Thanks a lot
Tilo
The text was updated successfully, but these errors were encountered: