Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Demo App for MXNet Inception Model using NNStreamer #287

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

SungwonShim
Copy link

Creative Integrated Design 1

Overall Description

This patch updated the function of 'image-classification by MXNet model' to original 'style-transfer demo app of tflite model'.

Specification

At first, user can choose which version to use. Either original one or added function.

While implementing image-classification function, the screen for style transferred image was changed for image and result of classification together.

Then, the pipeline string desc, originally designed for style transfer and using tflite model was modified to use MXNet Inception model and image classification.

For additional functions that is used for matching of classfication result and text, codes at https://github.com/nnstreamer/api/blob/8f13519b763470333512421be525bb0e8b6465f2/java/android/nnstreamer/src/androidTest/java/org/nnsuite/nnstreamer/APITestPipeline.java#L674 was referenced.

Pictures below shows what have changed.
image

image

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [* ]Skipped
  2. Run test: [ ]Passed [ ]Failed [* ]Skipped

SungwonShim and others added 2 commits June 1, 2022 23:39
Fix original pipeline to MXNet pipeline for image classification

Signed-off-by: SungwonShim <[email protected]>
Add MXNet Inception model demo examples and add some new activities.

Signed-off-by: makesource <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Jun 8, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #287. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 8, 2022

:octocat: cibot: @SungwonShim, The last line of a text file must have a newline character. Please append a new line at the end of the line in android/example_app/gradle.properties.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 8, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

1 similar comment
@taos-ci
Copy link
Collaborator

taos-ci commented Jun 8, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

Fix new line errors in gradle.properties, AndroidManifest.xml

Signed-off-by: makesource <[email protected]>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SungwonShim, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md.

BTW, great thanks to your contribution. This is cool!

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nnstreamer-example/ci/repo-workers/pr-checker/287-202206101944000.7227520942688-562ec955b4c7b9df55624e7307b49914e33669c3/report/misspelling_result.txt.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 10, 2022

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@myungjoo
Copy link
Member

myungjoo commented Jun 10, 2022

  1. Squash "Update README.md" commits
  2. The file "inception.params" is too large. Let it download the file at build-time or application launch-time.
  3. Fixing errors of your own commits shouldn't be committed separately in your own PR. Squash them.
  4. There are commits without signed-off and proper commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants