Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting JSON file minification #14

Open
pilotkid opened this issue Dec 16, 2020 · 3 comments
Open

Supporting JSON file minification #14

pilotkid opened this issue Dec 16, 2020 · 3 comments
Labels
needs more votes Request needs more votes

Comments

@pilotkid
Copy link

Hello, I have a project that has a few JSON files in it. Does this action support the modification of JSON files?

@nizarmah
Copy link
Owner

nizarmah commented Aug 13, 2021

Hello @pilotkid! I'm really sorry for this really late response.

The action doesn't support the modification of JSON files.

At the moment, this change will require some significant effort on my end to search for an appropriate library to use for the minification of the JSON files or if I'll need to create a small command to grep all whitespaces and necessary minifications for JSON.

Accordingly, before implementing such a feature, I prefer to wait until more users request such a feature.

If you're still in need of JSON minification, feel free please to open a pull request and ping me for review 😃

@nizarmah nizarmah self-assigned this Aug 13, 2021
@nizarmah nizarmah added the question Further information is requested label Aug 13, 2021
@nizarmah nizarmah removed their assignment Aug 15, 2021
@nizarmah nizarmah added needs more votes Request needs more votes and removed question Further information is requested labels Aug 15, 2021
@nizarmah nizarmah changed the title Can this minify JSON files? Supporting JSON file minification Aug 15, 2021
@stretch07
Copy link

@nizarmah how exactly do we vote? I'll add a thumbs-up reaction

@nizarmah
Copy link
Owner

nizarmah commented Mar 7, 2024

Hey @stretch07. Yes, please, give a thumbs up to the original comment.

If you have any suggestions (maybe a discussion post), let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more votes Request needs more votes
Projects
None yet
Development

No branches or pull requests

3 participants