Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239
This adds support for
pyproject.toml
that hasurl
with.whl
and built withpreferWheels = true
.poetry2nix
's previous behavior reinstalls (by fetching from the specified url) the wheel AFTER the dependencies (including the wheel-via-url) are resolved and patched onto the Python environment from unerased wheel dependency frompyproject
This is frompipInstallHook
running at installPhase.poetry2nix/mk-poetry-dep.nix
Line 120 in 5b3a515
We are relaxing this install phase by having
pyproject
accept any version of the installed package, which should become a no-op because our materializedpython
already has this dependency attached with a dependencies hook within other special dep hooks that we already have.On the topic of data science packages, we did also discover potentially unintended behavior with pytorch from #1109. We seem to require libcuda to be installed/managed separately, since
ml-stack
anduse-url-wheel
tests go through correctly in Darwin (which doesn't require CUDA!), but fails at x86_64 CI. I did added aHACK
stanza on skipping this part of integration test.