-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnePerRequestHttpModule does not perform its cleanup work #40
Comments
The issue seems to actually come from nuget package dependencies, not from the code. Version 3.2.1 of the mvc package should apparently require higher version of web.common package to function properly. |
When installing the latest nuget package (3.2.1), I noticed that disposable components in request scope were no longer properly cleaned up (Dispose() not called at request end). When downgrading to 3.2.0, all is fine. After looking at the code, it seems that MvcModule no longer inherits from GlobalKernelRegistrationModule, but directly from NinjectModule. Consequently, the kernel instance is no longer in GlobalKernelRegistration, and the MapKernels call in OnePerRequestHttpModule has no effect.
Am I missing something (some config, or module to load)? Or is it an issue in the generated code when installing the nuget package? Or possibly a bug?
The text was updated successfully, but these errors were encountered: