Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release blocked by failing integration tests #33

Open
ghost opened this issue Dec 14, 2021 · 1 comment
Open

Release blocked by failing integration tests #33

ghost opened this issue Dec 14, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 14, 2021

I did a dry run using the maven-release-plugin to check if I can also file a release PR.

The following two integration tests fail, however:

ApplicationControllerFluentLeniumTest.testThatHomepageWorks:41 null
ApplicationControllerTest.testThatHomepageWorks:42 null

As there is no further documentation concerning where and how these integration tests are supposed to be run, I can't tell if they need fixing or how I could fix them.

@raphaelbauer any pointers?

@thibaultmeyer
Copy link

thibaultmeyer commented Dec 31, 2021

Hello @vpriesner ,

Just test with code from "develop" branch. I got error on the same file. If you do not encounter the same error, can you attach the contents of the mvn package command?

Environment

Java

java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)

Ninja

6.8.1

Ninja Appengine

1.9.77-SNAPSHOT

Error

Error occure when rendering the template. The tag <#noescape> does not exist anymore and must be replaced by ?no_esc on the file src/main/java/views/ApplicationController/index.ftl.html.

Before

<p><#noescape>${frontArticle.content}</#noescape></p>

Now

<p>${frontArticle.content?no_esc}</p>

It will be necessary to open a Merge Request.

raphaelbauer added a commit that referenced this issue Jan 3, 2022
#33 Fixing integration tests as per @thibaultmeyer's suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant