Minor: ranch_ssl:listen can return non-atom error reasons

[gomoripeti]

According to the ranch_transport behaviour, listen/1 callback should return only atoms as error reasons https://github.com/ninenines/ranch/blob/master/src/ranch_transport.erl#L31. However ssl:listen and hence ranch_ssl:listen/1 can return more sophisticated error reasons as visible in ssl:format_error/1.

A quick fix would be to use ssl:format_error instead of inet:format_error in (

ranch/src/ranch_acceptors_sup.erl

Line 114 in a8f31f3

inet:format_error(Reason).

) (the former fall back to the later so works for non-ssl connections too)

Maybe a more generic solution would be if Transport behaviour would have an optional format_error callback and ranch_ssl would implement it calling ssl:format_error.

Not sure which one is preferred?

As an example the below crash happens if a non-existing cipher is provided in the options (seen with Erlang 26.2.5)

{failed_to_start_child,ranch_acceptors_sup,
 {badarg,
  [{erlang,atom_to_binary,
    [{options,
      {ciphers,
       [
       ...
       ]}}],
    [{error_info,#{module => erl_erts_errors}}]},
   {erl_posix_msg,message_1,1,
    [{file,"erl_posix_msg.erl"},{line,175}]},
   {erl_posix_msg,message,1,
    [{file,"erl_posix_msg.erl"},{line,29}]},
   {ranch_acceptors_sup,listen_error,5,
    [{file,"src/ranch_acceptors_sup.erl"},
     {line,95}]},
   {ranch_acceptors_sup,start_listen_sockets,5,
    [{file,"src/ranch_acceptors_sup.erl"},
     {line,54}]},
   {ranch_acceptors_sup,init,1,
    [{file,"src/ranch_acceptors_sup.erl"},
     {line,34}]},

[essen]

An optional format_error callback is probably the best solution.

[gomoripeti]

thanks for the feedback, I will work on a patch

[essen]

If you'd like to work on this, this is a great time to do it as I will release a new version soon. Otherwise I will probably just change the listen return value to any() instead of atom().

[gomoripeti]

sorry, I did not have time last week, so probably I wont' have time soon either :(