Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the relx Windows start script #363

Open
essen opened this issue Sep 14, 2015 · 2 comments
Open

Improve the relx Windows start script #363

essen opened this issue Sep 14, 2015 · 2 comments

Comments

@essen
Copy link
Member

essen commented Sep 14, 2015

On Windows the script doesn't behave very well, in particular when an error happens, it will still return 0. It should be good to return 1 on failure. Currently the tests for bootstrap-rel will work regardless of the release starting properly, for example. (Note that this test require administrator rights in order to install the release as a service.)

I'm also having trouble with Erlang not able to start distribution for some reasons, but that could very well be just me.

@essen
Copy link
Member Author

essen commented Sep 29, 2015

@essen essen removed Bug labels Dec 4, 2018
@essen
Copy link
Member Author

essen commented Jun 25, 2019

There's a bunch of issues I had to disable or try working around in the relx-relup and relx-start-stop tests. https://github.com/ninenines/erlang.mk/blob/master/test/plugin_relx.mk#L157

Would be good to revisit later. In particular, trying to update Relx to the most recent version. But I believe most of these issues remain based on a quick reading of the code of Relx master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant