Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure config options are accessible #3123

Open
paberr opened this issue Nov 21, 2024 · 0 comments
Open

Make sure config options are accessible #3123

paberr opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@paberr
Copy link
Member

paberr commented Nov 21, 2024

There is a chance that what happened to max_epochs_stored (#3112) is also happening to other config options:
When moving options from the struct responsible for deserialization to the actual config object, we might miss out on some options.

We should destructure the config to make sure all fields are used.

@paberr paberr added bug Something isn't working enhancement New feature or request labels Nov 21, 2024
@hrxi hrxi removed the enhancement New feature or request label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants