Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gh394] Remove the Figaro gem dependency #400

Closed
wants to merge 9 commits into from
Closed

[gh394] Remove the Figaro gem dependency #400

wants to merge 9 commits into from

Conversation

malparty
Copy link
Member

@malparty malparty commented Mar 24, 2023 •
edited
Loading

What happened 👀

Remove the figaro dependency in favor of dotenv gem and a .env.example file

  • Update the needed files
  • Update the tests (review in progress)
  • Test the changes with a deployed project 🤖

Insight 📝

n/a

Proof Of Work 📹

Local project generated from this branch:

image

Test can run Project can run
image image

@malparty malparty added this to the 5.5.0 milestone Mar 24, 2023
@malparty malparty self-assigned this Mar 24, 2023
@malparty malparty modified the milestones: 5.5.0, 5.6.0 Apr 7, 2023
@longnd longnd mentioned this pull request Apr 20, 2023
Open
@malparty malparty force-pushed the feature/gh394-remove-figaro-gem-dependency branch 8 times, most recently from 0757d3f to a50529d Compare April 28, 2023 02:47
@malparty malparty force-pushed the feature/gh394-remove-figaro-gem-dependency branch 16 times, most recently from a2d409d to c83a45f Compare June 2, 2023 09:02
@malparty malparty force-pushed the feature/gh394-remove-figaro-gem-dependency branch 3 times, most recently from 08e6958 to 671e9f5 Compare June 5, 2023 10:15
@malparty malparty force-pushed the feature/gh394-remove-figaro-gem-dependency branch from 671e9f5 to 18fc0ac Compare June 5, 2023 12:14
@malparty malparty force-pushed the feature/gh394-remove-figaro-gem-dependency branch 5 times, most recently from 52fef6a to f78291b Compare June 6, 2023 06:14
@malparty malparty force-pushed the feature/gh394-remove-figaro-gem-dependency branch from f78291b to 771ccd2 Compare June 6, 2023 06:20
@malparty
Copy link
Member Author

@malparty you should try that:

image

@malparty malparty modified the milestones: 5.6.0, 5.7.0 Jun 22, 2023
caherrerapa
caherrerapa reviewed Jun 22, 2023
View reviewed changes
config/database.yml.tt
database: <%= ENV.fetch('DB_NAME') { APP_NAME } %>_test

production:
url: <%= ENV.fetch('DATABASE_URL') { '' } %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will only work for heroku afaik

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Andy found a part of the solution in #411 — but the implementation still require some improvements 💭

@malparty malparty modified the milestones: 5.7.0, 5.8.0 Jul 26, 2023
@malparty malparty modified the milestones: 5.8.0, 5.9.0 Sep 14, 2023
@malparty malparty modified the milestones: 5.9.0, 5.10.0 Sep 29, 2023
@malparty malparty modified the milestones: 5.10.0, 5.11.0 Nov 2, 2023
@malparty malparty modified the milestones: 5.11.0, 5.12.0 Dec 14, 2023
@malparty
Copy link
Member Author

I will close this PR as with the recent changes, it will be wiser to start it from scratch again 👍
I will add this PR as reference in the associated issue.

@malparty malparty closed this Jan 11, 2024
@malparty malparty mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caherrerapa caherrerapa caherrerapa left review comments

@aetheryna aetheryna Awaiting requested review from aetheryna aetheryna will be requested when the pull request is marked ready for review aetheryna is a code owner

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 will be requested when the pull request is marked ready for review andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone will be requested when the pull request is marked ready for review bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt will be requested when the pull request is marked ready for review byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall will be requested when the pull request is marked ready for review carryall is a code owner

@Goose97 Goose97 Awaiting requested review from Goose97 Goose97 will be requested when the pull request is marked ready for review Goose97 is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs will be requested when the pull request is marked ready for review hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd will be requested when the pull request is marked ready for review longnd is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu will be requested when the pull request is marked ready for review vnntsu is a code owner

@sanG-github sanG-github Awaiting requested review from sanG-github sanG-github will be requested when the pull request is marked ready for review sanG-github is a code owner

Assignees

@malparty malparty

Labels
type : feature
Projects
None yet
Milestone
5.12.0
Development

Successfully merging this pull request may close these issues.

Remove the Figaro gem dependency
2 participants
@malparty @caherrerapa