Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#528] Update Default timeout for Keychain to no time-out #529

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[#528] Update Default timeout for Keychain to no time-out #529

merged 2 commits into from
Oct 31, 2023

Conversation

blyscuit
Copy link
Collaborator

@blyscuit blyscuit commented Oct 5, 2023 •
edited
Loading

What happened 👀

Update timeout for keychain to no 1.2 days.

Insight 📝

  • I decided to use 1.2 days instead of no time-out because I have concern with keychains that never gets deleted could be remotely hacked.
  • There will be a timer to remove keychains nightly on self-hosted.

Proof Of Work 📹

This keychain had been unlocked for 2 hr+.

Screenshot 2023-10-05 at 13 06 41

@blyscuit blyscuit self-assigned this Oct 5, 2023
@blyscuit blyscuit changed the base branch from main to develop October 5, 2023 06:07
@blyscuit blyscuit added this to the 4.9.0 milestone Oct 5, 2023
@blyscuit blyscuit changed the title [#528] [Chore] Update Default timeout for Keychain to no time-out [#528] Update Default timeout for Keychain to no time-out Oct 5, 2023
@blyscuit blyscuit marked this pull request as ready for review October 5, 2023 08:33
@blyscuit blyscuit modified the milestones: 4.9.0, 4.10.0 Oct 17, 2023
@blyscuit blyscuit added this pull request to the merge queue Oct 31, 2023
Merged via the queue into develop with commit ffca168 Oct 31, 2023
4 checks passed
@blyscuit blyscuit deleted the chore/#528-keychain-no-timeout branch October 31, 2023 04:47
@blyscuit blyscuit mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhanh44 nkhanh44 nkhanh44 approved these changes

@ducbm051291 ducbm051291 ducbm051291 approved these changes

@phongvhd93 phongvhd93 phongvhd93 approved these changes

@suho suho suho approved these changes

@markgravity markgravity Awaiting requested review from markgravity markgravity is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

Assignees

@blyscuit blyscuit

Labels
type : chore
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

[Chore] Update Default timeout for Keychain to no time-out
5 participants
@blyscuit @suho @phongvhd93 @ducbm051291 @nkhanh44