Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Danger xcov report won't work correctly when Constants.TESTS_SCHEME is different with PRODUCT_NAME #307

Open
markgravity opened this issue Jul 22, 2022 · 0 comments
Assignees

Comments

@markgravity
Copy link
Contributor

markgravity commented Jul 22, 2022

Issue

Danger xcov report won't show Code Coverage report when Schema name is different with PRODUCT_NAME, if we use only_project_targets: true

And the solution is from @minhnimble on his PR

Expected

Danger should show Code Coverage report
Screen Shot 2022-07-22 at 10 29 13

Steps to reproduce

  1. Create a new project from `ios-template
  2. Change PRODUCT_NAME in Build Settings to make it different from the Constants.TESTS_SCHEME
  3. Run bundle exec danger local
    Screen Shot 2022-07-22 at 10 23 00
@markgravity markgravity changed the title Fix: Danger xcov report won't work correctly when Schema name is different with PRODUCT_NAME Fix: Danger xcov report won't work correctly when Constants.TESTS_SCHEME is different with PRODUCT_NAME Jul 22, 2022
@markgravity markgravity added this to the 3.9.0 milestone Aug 2, 2022
@nkhanh44 nkhanh44 self-assigned this Aug 4, 2022
@suho suho removed @3.9.0 labels Aug 15, 2022
@markgravity markgravity modified the milestones: 3.9.0, 3.10.0 Aug 30, 2022
@markgravity markgravity modified the milestones: 3.10.0, 3.11.0 Sep 28, 2022
@vnntsu vnntsu modified the milestones: 3.11.0, 3.12.0 Nov 7, 2022
@vnntsu vnntsu modified the milestones: 3.12.0, 3.13.0 Nov 30, 2022
@vnntsu vnntsu modified the milestones: 4.0.0, 4.1.0 Jan 3, 2023
@vnntsu vnntsu modified the milestones: 4.1.0, 4.2.0 Jan 31, 2023
@vnntsu vnntsu removed this from the 4.2.0 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants