From 59c001416119408d9e9c0d9e9e9d3661dab3130c Mon Sep 17 00:00:00 2001 From: Doan Dinh Date: Fri, 3 Nov 2023 10:39:33 +0700 Subject: [PATCH] [#198] Test using shorten pr --- .github/workflows/android_deploy_production.yml | 9 +-------- .github/workflows/android_deploy_staging.yml | 10 ++-------- .../.github/workflows/android_deploy_production.yml | 9 +-------- .../.github/workflows/android_deploy_staging.yml | 9 +-------- 4 files changed, 5 insertions(+), 32 deletions(-) diff --git a/.github/workflows/android_deploy_production.yml b/.github/workflows/android_deploy_production.yml index 13f2f9af..aee293dd 100644 --- a/.github/workflows/android_deploy_production.yml +++ b/.github/workflows/android_deploy_production.yml @@ -61,18 +61,11 @@ jobs: uses: 8BitJonny/gh-get-current-pr@2.2.0 id: PR - - name: Generate release notes - env: - PR_CONTENT: ${{ steps.PR.outputs.pr_body }} - id: generate-release-notes - run: | - echo "RELEASE_NOTE_CONTENT=$PR_CONTENT" >> $GITHUB_OUTPUT - - name: Deploy Android Production to Firebase uses: wzieba/Firebase-Distribution-Github-Action@v1.5.0 with: appId: ${{ vars.FIREBASE_ANDROID_APP_ID }} serviceCredentialsFileContent: ${{ secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON }} groups: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }} - releaseNotes: ${{steps.generate-release-notes.outputs.RELEASE_NOTE_CONTENT}} + releaseNotes: ${{ steps.PR.outputs.pr_body }} file: build/app/outputs/flutter-apk/app-production-release.apk diff --git a/.github/workflows/android_deploy_staging.yml b/.github/workflows/android_deploy_staging.yml index da3a575d..7a3a3fdf 100644 --- a/.github/workflows/android_deploy_staging.yml +++ b/.github/workflows/android_deploy_staging.yml @@ -4,6 +4,7 @@ on: push: branches: - develop + - chore/198-add-release-note-firebase-deploy jobs: build_and_deploy_android: @@ -53,18 +54,11 @@ jobs: uses: 8BitJonny/gh-get-current-pr@2.2.0 id: PR - - name: Generate release notes - env: - PR_TITLE: ${{ steps.PR.outputs.pr_title }} - id: generate-release-notes - run: | - echo "RELEASE_NOTE_CONTENT=$PR_TITLE" >> $GITHUB_OUTPUT - - name: Deploy Android Staging to Firebase uses: wzieba/Firebase-Distribution-Github-Action@v1.5.0 with: appId: ${{ vars.FIREBASE_ANDROID_APP_ID }} serviceCredentialsFileContent: ${{ secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON }} groups: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }} - releaseNotes: ${{ steps.generate-release-notes.outputs.RELEASE_NOTE_CONTENT }} + releaseNotes: ${{ steps.PR.outputs.pr_title }} file: build/app/outputs/flutter-apk/app-staging-debug.apk diff --git a/bricks/template/__brick__/.github/workflows/android_deploy_production.yml b/bricks/template/__brick__/.github/workflows/android_deploy_production.yml index 88d22852..12758f8b 100644 --- a/bricks/template/__brick__/.github/workflows/android_deploy_production.yml +++ b/bricks/template/__brick__/.github/workflows/android_deploy_production.yml @@ -55,18 +55,11 @@ jobs: uses: 8BitJonny/gh-get-current-pr@2.2.0 id: PR - - name: Generate release notes - env: - PR_CONTENT: ${{#mustacheCase}}steps.PR.outputs.pr_body{{/mustacheCase}} - id: generate-release-notes - run: | - echo "RELEASE_NOTE_CONTENT=$PR_CONTENT" >> $GITHUB_OUTPUT - - name: Deploy Android Production to Firebase uses: wzieba/Firebase-Distribution-Github-Action@v1.5.0 with: appId: ${{#mustacheCase}}vars.FIREBASE_ANDROID_APP_ID{{/mustacheCase}} serviceCredentialsFileContent: ${{#mustacheCase}}secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON{{/mustacheCase}} groups: ${{#mustacheCase}}vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS{{/mustacheCase}} - releaseNotes: ${{#mustacheCase}}steps.generate-release-notes.outputs.RELEASE_NOTE_CONTENT{{/mustacheCase}} + releaseNotes: ${{#mustacheCase}}steps.PR.outputs.pr_body{{/mustacheCase}} file: build/app/outputs/flutter-apk/app-production-debug.apk diff --git a/bricks/template/__brick__/.github/workflows/android_deploy_staging.yml b/bricks/template/__brick__/.github/workflows/android_deploy_staging.yml index ace5b481..7e9e7239 100644 --- a/bricks/template/__brick__/.github/workflows/android_deploy_staging.yml +++ b/bricks/template/__brick__/.github/workflows/android_deploy_staging.yml @@ -47,18 +47,11 @@ jobs: uses: 8BitJonny/gh-get-current-pr@2.2.0 id: PR - - name: Generate release notes - env: - PR_TITLE: ${{#mustacheCase}}steps.PR.outputs.pr_title{{/mustacheCase}} - id: generate-release-notes - run: | - echo "RELEASE_NOTE_CONTENT=$PR_TITLE" >> $GITHUB_OUTPUT - - name: Deploy Android Staging to Firebase uses: wzieba/Firebase-Distribution-Github-Action@v1.5.0 with: appId: ${{#mustacheCase}}vars.FIREBASE_ANDROID_APP_ID{{/mustacheCase}} serviceCredentialsFileContent: ${{#mustacheCase}}secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON{{/mustacheCase}} groups: ${{#mustacheCase}}vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS{{/mustacheCase}} - releaseNotes: ${{#mustacheCase}}steps.generate-release-notes.outputs.RELEASE_NOTE_CONTENT{{/mustacheCase}} + releaseNotes: ${{#mustacheCase}}steps.PR.outputs.pr_title{{/mustacheCase}} file: build/app/outputs/flutter-apk/app-staging-debug.apk