From ec3d4b8630879b0f5294f660431f4a9d607285db Mon Sep 17 00:00:00 2001 From: Andy Duong Date: Fri, 10 Mar 2023 13:46:06 +0700 Subject: [PATCH] [gh315] Do not need --no-live when the --no-html is given --- .github/wiki/Generation.md | 2 +- .github/wiki/Testing.md | 6 +++--- .github/workflows/apply_api_variant.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/wiki/Generation.md b/.github/wiki/Generation.md index 8ba436cc..21550896 100644 --- a/.github/wiki/Generation.md +++ b/.github/wiki/Generation.md @@ -36,7 +36,7 @@ Modify the path to locate the `elixir-templates` directory. For example `~/elixi - Web project: `make create_phoenix_project PROJECT_DIRECTORY=sample_project OPTIONS="--no-live"` - Live project: `make create_phoenix_project PROJECT_DIRECTORY=sample_project OPTIONS=""` -- API project: `make create_phoenix_project PROJECT_DIRECTORY=sample_project OPTIONS="--no-html --no-assets --no-live"` +- API project: `make create_phoenix_project PROJECT_DIRECTORY=sample_project OPTIONS="--no-html --no-assets"` 3. Answer the prompt `Fetch and install dependencies? [Yn]` with `n` (not install) diff --git a/.github/wiki/Testing.md b/.github/wiki/Testing.md index ccd2a771..8c6760fe 100644 --- a/.github/wiki/Testing.md +++ b/.github/wiki/Testing.md @@ -83,7 +83,7 @@ mix phx.new awesome_project - API variants do NOT support HTML and Assets configuration. ```bash -mix phx.new awesome_project --no-html --no-assets --no-live +mix phx.new awesome_project --no-html --no-assets ``` - Custom project variants allow us to modify the app name or module name. @@ -108,8 +108,8 @@ Web project API project -- Standard (`mix phx.new awesome_project --no-html --no-assets --no-live`) -- Custom (`mix phx.new awesome_project --no-html --no-assets --no-live --module=CustomModuleName --app=custom_otp_app_name`) +- Standard (`mix phx.new awesome_project --no-html --no-assets`) +- Custom (`mix phx.new awesome_project --no-html --no-assets --module=CustomModuleName --app=custom_otp_app_name`) LiveView project diff --git a/.github/workflows/apply_api_variant.yml b/.github/workflows/apply_api_variant.yml index 39d76810..d1161296 100644 --- a/.github/workflows/apply_api_variant.yml +++ b/.github/workflows/apply_api_variant.yml @@ -7,14 +7,14 @@ jobs: name: Test on a Standard API project uses: ./.github/workflows/reusable_phoenix_project.yml with: - new_project_options: "--no-html --no-assets --no-live" + new_project_options: "--no-html --no-assets" variant: "api" long_custom_name_api_project: name: Test on a long custom name API project uses: ./.github/workflows/reusable_phoenix_project.yml with: - new_project_options: "--no-html --no-assets --no-live --module=SampleCustomModule --app=sample_custom_app" + new_project_options: "--no-html --no-assets --module=SampleCustomModule --app=sample_custom_app" variant: "api" short_custom_name_api_project: