From ea896b7734d9845833c56991d9c4ae09f91c96ef Mon Sep 17 00:00:00 2001 From: Luong Vo Date: Thu, 18 Jul 2024 12:32:44 +0700 Subject: [PATCH 1/5] [#580] Hide Compose androidx.compose.ui.tooling.PreviewActivity from the final release build https://developer.android.com/develop/ui/compose/tooling --- template-compose/app/build.gradle.kts | 3 ++- template-compose/buildSrc/src/main/java/Dependencies.kt | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/template-compose/app/build.gradle.kts b/template-compose/app/build.gradle.kts index ed899e49b..54b11d1ee 100644 --- a/template-compose/app/build.gradle.kts +++ b/template-compose/app/build.gradle.kts @@ -143,7 +143,8 @@ dependencies { with(Dependencies.Compose) { implementation(platform(BOM)) implementation(UI) - implementation(UI_TOOLING) + debugImplementation(UI_TOOLING) + implementation(UI_TOOLING_PREVIEW) implementation(MATERIAL) implementation(NAVIGATION) diff --git a/template-compose/buildSrc/src/main/java/Dependencies.kt b/template-compose/buildSrc/src/main/java/Dependencies.kt index 1bbba810a..06c295647 100644 --- a/template-compose/buildSrc/src/main/java/Dependencies.kt +++ b/template-compose/buildSrc/src/main/java/Dependencies.kt @@ -11,8 +11,8 @@ object Dependencies { object Compose { const val BOM = "androidx.compose:compose-bom:${Versions.COMPOSE_BOM}" const val UI = "androidx.compose.ui:ui" - const val UI_GRAPHICS = "androidx.compose.ui:ui-graphics" const val UI_TOOLING = "androidx.compose.ui:ui-tooling" + const val UI_TOOLING_PREVIEW = "androidx.compose.ui:ui-tooling-preview" const val MATERIAL = "androidx.compose.material:material" const val NAVIGATION = "androidx.navigation:navigation-compose:${Versions.COMPOSE_NAVIGATION}" From e438d485795c09960f46eac4e4455f78cffe1523 Mon Sep 17 00:00:00 2001 From: ryan-conway Date: Thu, 1 Aug 2024 02:51:25 +0000 Subject: [PATCH 2/5] [Chore] Bump version to 3.30.0 --- sample-compose/buildSrc/src/main/java/Versions.kt | 2 +- version.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sample-compose/buildSrc/src/main/java/Versions.kt b/sample-compose/buildSrc/src/main/java/Versions.kt index b3ac0e98c..e7da5ae3e 100644 --- a/sample-compose/buildSrc/src/main/java/Versions.kt +++ b/sample-compose/buildSrc/src/main/java/Versions.kt @@ -6,7 +6,7 @@ object Versions { const val ANDROID_TARGET_SDK_VERSION = 33 const val ANDROID_VERSION_CODE = 1 - const val ANDROID_VERSION_NAME = "3.29.0" + const val ANDROID_VERSION_NAME = "3.30.0" // Dependencies (Alphabet sorted) const val ACCOMPANIST_VERSION = "0.30.1" diff --git a/version.properties b/version.properties index 59413f152..05aa95020 100644 --- a/version.properties +++ b/version.properties @@ -1,3 +1,3 @@ kotlinVersion=1.6.21 kscriptVersion=4.0.3 -templateScriptVersion=3.29.0 +templateScriptVersion=3.30.0 From 25f270afb143be35fb724cb52ebd5e0fef01ae98 Mon Sep 17 00:00:00 2001 From: Ryan Conway Date: Thu, 1 Aug 2024 09:57:32 +0700 Subject: [PATCH 3/5] [Chore] Update codeowners --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5ebe17102..9e6a1694d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,6 @@ # Team # @ryan-conway is the Team Lead and the others are team members -* @AVI5HEK @chornerman @doannimble @hoangnguyen92dn @Johnsonmaung @kaungkhantsoe @luongvo @manh-t @minhnimble @ryan-conway @sleepylee @thiennguyen0196 @toby-thanathip +* @AVI5HEK @chornerman @hoangnguyen92dn @Johnsonmaung @kaungkhantsoe @luongvo @manh-t @minhnimble @nyinyihtunlwin-dev @RkNaing @ryan-conway @sleepylee @thawzintoe-ptut @toby-thanathip @win-than-htike # Engineering Leads CODEOWNERS @nimblehq/engineering-leads From 27e45e110b8e062b4de173f5406c20a4959cb7ec Mon Sep 17 00:00:00 2001 From: Kaung Khant Soe Date: Fri, 25 Oct 2024 11:17:32 +0700 Subject: [PATCH 4/5] [Chore] Add tiger as codeowner --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9e6a1694d..be362c845 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,6 @@ # Team # @ryan-conway is the Team Lead and the others are team members -* @AVI5HEK @chornerman @hoangnguyen92dn @Johnsonmaung @kaungkhantsoe @luongvo @manh-t @minhnimble @nyinyihtunlwin-dev @RkNaing @ryan-conway @sleepylee @thawzintoe-ptut @toby-thanathip @win-than-htike +* @AVI5HEK @chornerman @eeeeaa @hoangnguyen92dn @Johnsonmaung @kaungkhantsoe @luongvo @manh-t @minhnimble @nyinyihtunlwin-dev @RkNaing @ryan-conway @sleepylee @thawzintoe-ptut @toby-thanathip @win-than-htike # Engineering Leads CODEOWNERS @nimblehq/engineering-leads From 3841562982d210a2bc97b24a835e5a6ff7971d77 Mon Sep 17 00:00:00 2001 From: Kaung Khant Soe Date: Fri, 25 Oct 2024 11:42:31 +0700 Subject: [PATCH 5/5] [Chore] Remove nyi nyi from code owner --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index be362c845..dccd9756e 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,6 @@ # Team # @ryan-conway is the Team Lead and the others are team members -* @AVI5HEK @chornerman @eeeeaa @hoangnguyen92dn @Johnsonmaung @kaungkhantsoe @luongvo @manh-t @minhnimble @nyinyihtunlwin-dev @RkNaing @ryan-conway @sleepylee @thawzintoe-ptut @toby-thanathip @win-than-htike +* @AVI5HEK @chornerman @eeeeaa @hoangnguyen92dn @Johnsonmaung @kaungkhantsoe @luongvo @manh-t @minhnimble @RkNaing @ryan-conway @sleepylee @thawzintoe-ptut @toby-thanathip @win-than-htike # Engineering Leads CODEOWNERS @nimblehq/engineering-leads