Revise .cicdtemplate for Github Actions

[hoangnguyen92dn]

Why

There are some points to revamp the current CI/CD template to have workflow ready to work in new projects:
https://github.com/nimblehq/android-templates/tree/develop/.cicdtemplate/.github

• Remove unused templates since it's out of date and unmaintained, the team need to reference to git-template as single source truth and latest update for new projects:

---

• Combine reviewing PR workflows: review_pull_request.yml && run_detekt_and_unit_tests.yml. Both workflow have the same steps can be extract to shared workflow to reuse (Reference: https://docs.github.com/en/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization).

---

• Revamp the deployment workflow: deploy_staging_and_production_to_firebase_app_distribution.yml. Github supports environment for deployment therefore creating variables/secretes with environment suffix is unnecessary (Reference: https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment)

Who Benefits?

Developers

[luongvo]

Remove unused templates since it's out of date and unmantainced, the team need to reference to git-template as single source truth and latest update for new projects:

@hoangnguyen92dn Instead of remove, IMO, we should keep them up to date or have a script to sync them when generating new projects.

Revamp the deployment workflow: deploy_staging_and_production_to_firebase_app_distribution.yml. Github supports environment for deployment therefore creating variables/secretes with environment suffix is unnecessary

Agree, we should separate Environment variables by env: production and staging instead of by template: template-compose and template-xml.

The rest lgtm.

[hoangnguyen92dn]

@luongvo In fact, when the team create new repo, I see that choosing git-template from the options would be more efficient 😅

[luongvo]

@hoangnguyen92dn Yes, but then, we will generate and push up the generated initial project from our Template.