Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#423] Clean up warnings when generating a new project #507

Closed
wants to merge 1 commit into from
Closed

[#423] Clean up warnings when generating a new project #507

wants to merge 1 commit into from

Conversation

ryan-conway
Copy link
Collaborator

@ryan-conway ryan-conway commented Aug 22, 2023 •
edited
Loading

closes #423

What happened 👀

  • Moved namespace declarations from AndroidManifest.xml files to build.gradle files
  • Fixed mismatched parameter name

Insight 📝

We still receive the following warning when building

> Task :buildSrc:jar
:jar: No valid plugin descriptors were found in META-INF/gradle-plugins

It seems to have been fixed in Gradle 8.3, but as the current stable Android Gradle plugin is on 8.1.2, we will still receive this warning for now 👀

Proof Of Work 📹

Verify newproject script log

@ryan-conway ryan-conway self-assigned this Aug 22, 2023
@ryan-conway ryan-conway temporarily deployed to template-compose August 22, 2023 06:58 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited
Loading

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 34.25%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AppPreferencesRepository.kt
build.gradle.kts
build.gradle.kts

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.05%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AppPreferencesRepository.kt
build.gradle.kts
build.gradle.kts

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@ryan-conway ryan-conway force-pushed the chore/423-clean-up-warnings-when-generating-a-new-project branch from 8be9863 to e7c1330 Compare August 22, 2023 07:20
@ryan-conway ryan-conway temporarily deployed to template-compose August 22, 2023 07:20 — with GitHub Actions Inactive
@ryan-conway ryan-conway force-pushed the chore/423-clean-up-warnings-when-generating-a-new-project branch from e7c1330 to 7f4333c Compare August 22, 2023 07:22
@ryan-conway ryan-conway temporarily deployed to template-compose August 22, 2023 07:22 — with GitHub Actions Inactive
@ryan-conway ryan-conway force-pushed the chore/423-clean-up-warnings-when-generating-a-new-project branch from 7f4333c to b86d602 Compare August 22, 2023 07:32
@ryan-conway ryan-conway temporarily deployed to template-compose August 22, 2023 07:32 — with GitHub Actions Inactive
@ryan-conway ryan-conway temporarily deployed to template-compose August 22, 2023 07:33 — with GitHub Actions Inactive
@ryan-conway ryan-conway force-pushed the chore/423-clean-up-warnings-when-generating-a-new-project branch from b86d602 to e27e715 Compare October 5, 2023 09:48
@ryan-conway ryan-conway temporarily deployed to template-compose October 5, 2023 09:48 — with GitHub Actions Inactive
@ryan-conway ryan-conway temporarily deployed to template-compose October 5, 2023 09:53 — with GitHub Actions Inactive
@ryan-conway ryan-conway temporarily deployed to template-compose October 5, 2023 10:59 — with GitHub Actions Inactive
@ryan-conway ryan-conway closed this Oct 9, 2023
@ryan-conway ryan-conway deleted the chore/423-clean-up-warnings-when-generating-a-new-project branch October 16, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK will be requested when the pull request is marked ready for review AVI5HEK is a code owner

@chornerman chornerman Awaiting requested review from chornerman chornerman will be requested when the pull request is marked ready for review chornerman is a code owner

@eeeeaa eeeeaa Awaiting requested review from eeeeaa eeeeaa will be requested when the pull request is marked ready for review eeeeaa is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn will be requested when the pull request is marked ready for review hoangnguyen92dn is a code owner

@Johnsonmaung Johnsonmaung Awaiting requested review from Johnsonmaung Johnsonmaung will be requested when the pull request is marked ready for review Johnsonmaung is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe will be requested when the pull request is marked ready for review kaungkhantsoe is a code owner

@luongvo luongvo Awaiting requested review from luongvo luongvo will be requested when the pull request is marked ready for review luongvo is a code owner

@manh-t manh-t Awaiting requested review from manh-t manh-t will be requested when the pull request is marked ready for review manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble will be requested when the pull request is marked ready for review minhnimble is a code owner

@RkNaing RkNaing Awaiting requested review from RkNaing RkNaing will be requested when the pull request is marked ready for review RkNaing is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee will be requested when the pull request is marked ready for review sleepylee is a code owner

@thawzintoe-ptut thawzintoe-ptut Awaiting requested review from thawzintoe-ptut thawzintoe-ptut will be requested when the pull request is marked ready for review thawzintoe-ptut is a code owner

@toby-thanathip toby-thanathip Awaiting requested review from toby-thanathip toby-thanathip will be requested when the pull request is marked ready for review toby-thanathip is a code owner

@win-than-htike win-than-htike Awaiting requested review from win-than-htike win-than-htike will be requested when the pull request is marked ready for review win-than-htike is a code owner

Assignees

@ryan-conway ryan-conway

Labels
type : chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up warnings when generating a new project
1 participant
@ryan-conway