Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update static code analysis tool to ktlint instead of lint #342

Open
toby-thanathip opened this issue Nov 1, 2022 · 1 comment
Open

Update static code analysis tool to ktlint instead of lint #342

toby-thanathip opened this issue Nov 1, 2022 · 1 comment
Assignees
@thawzintoe-ptut
Labels
priority : normal type : chore

Comments

@toby-thanathip
Copy link
Contributor

toby-thanathip commented Nov 1, 2022 •
edited
Loading

Why

Ktlint will improve our Kotlin code quality with lint checks

Once approved we can drop this issue: #182

Acceptance Criteria

  • Add ktlint configurations
  • Remove lint configurations
  • Update workflows
  • Update Dangerfile
  • Update README.md

Who Benefits?

This is essential because it will improve the experience of developers
@toby-thanathip toby-thanathip added this to the 3.15.0 milestone Nov 1, 2022
@ryan-conway
Copy link
Collaborator

@Tuubz looks like we'll need to update our .gitignore files too since ktlint wants us to update .idea/codeStyles/codeStyleConfig.xml and .idea/codeStyles/Project.xml as well 🤔 ref

@toby-thanathip toby-thanathip removed this from the 3.15.0 milestone Dec 6, 2022
@thawzintoe-ptut thawzintoe-ptut self-assigned this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thawzintoe-ptut thawzintoe-ptut

Labels
priority : normal type : chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luongvo @toby-thanathip @thawzintoe-ptut @ryan-conway