Refactor template to expose event callback to navigate #593
kaungkhantsoe
started this conversation in
RFCs
Replies: 1 comment 1 reply
-
This approach has pros/cons and the team already discussed about this. Mentioning "not necessary" at this time doesn't sounds right, since we are agreed to go with this approach for long time ago. I'd agree that we need to do refactoring since following the best practices of navigation flow management, the screen level should expose the callback events. However, with this approach, we need to handle with UI/Integration Test to cover the logic. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Issue
navigator
from the BaseViewModel to navigate around, which is not necessarySolution
navigator
from the Screen level and ViewModel levelNavController.navigate
Who benefits?
Android developers
What's next?
2 votes ·
Beta Was this translation helpful? Give feedback.
All reactions