Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade core RBFs listead as well as MRAs #16

Open
molnara opened this issue Jun 5, 2020 · 4 comments
Open

Arcade core RBFs listead as well as MRAs #16

molnara opened this issue Jun 5, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@molnara
Copy link

molnara commented Jun 5, 2020

Describe the bug
Arcade core RBFs listed as well as MRAs which is confusing.

Describe your setup

  • WebMenu Version: v0.4.2rc1
  • MiSTer Version: v200602

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'http://mister'
  2. Click on 'Cores'
  3. Scroll down to 'Arcade'
  4. All the RBFs are being listed alongside the MRAs

Expected behavior
Only MRAs should be displayed.

Screenshots

arcade-core-rbfs

Web Browser:

  • OS: Windows 10
  • Browser Firefox
  • Version 76

Additional context
If I load some of the arcade RBFs, some work, mainly the ones that only support one game, but I don't think arcade RBFs should be displayed. Perfect example is jtcps1, this doesn't do anything if you try to run it, but this core will run any CPS1 MRA.

@molnara molnara added bug Something isn't working not confirmed labels Jun 5, 2020
@nilp0inter
Copy link
Owner

Yeah, I have to rethink this part.

Do you think hiding the RBF cores if and only if there is an MRA for that core is a good approach?

@nilp0inter nilp0inter added enhancement New feature or request and removed bug Something isn't working not confirmed labels Jun 6, 2020
@molnara
Copy link
Author

molnara commented Jun 6, 2020

I would just exclude /_Arcade/cores

I’m pretty sure all arcade cores use mra files now anyways.

@nilp0inter
Copy link
Owner

I am trying to avoid using the directory structure to infer information about the cores given that a lot of people have different directory layouts.

I will test the idea of hiding RBF which are mentioned in an MRA and publish an RC for you to try.

@nilp0inter nilp0inter added this to the v0.5.1 milestone Jun 8, 2020
@molnara
Copy link
Author

molnara commented Jun 9, 2020

_Arcade/cores is the standard location which the official update script uses. As I was mentioning before, if we have a settings option, we could just change it if it deviates from the default.

I would probably have the following settings with default settings:
Arcade core path /fat/_Arcade/cores
Arcade MRA path /fat/_Arcade
Console path /fat/_Consoles
Computer path /fat/_Computers
Games path /fat/games

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants