Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider Navigation isn't dynamic #157

Open
ceehaupt opened this issue Nov 20, 2021 · 0 comments
Open

Slider Navigation isn't dynamic #157

ceehaupt opened this issue Nov 20, 2021 · 0 comments

Comments

@ceehaupt
Copy link
Collaborator

ceehaupt commented Nov 20, 2021

In https://github.com/nikita-kit/generator-nikita/blob/master/app/templates/src/components-react/common/slider/Slider.js.ejs
the navigation is set by classes:
navigation: { nextEl: '.next', prevEl: '.prev', disabledClass: 'is-disabled', },
If you use the component multiple times on a site a click on the navigation will affect all components not just the one it should affect on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant