Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to display keys with a colon in the name #7

Open
luispollo opened this issue Sep 19, 2016 · 1 comment
Open

Failure to display keys with a colon in the name #7

luispollo opened this issue Sep 19, 2016 · 1 comment

Comments

@luispollo
Copy link
Contributor

luispollo commented Sep 19, 2016

When a key has a ':' in its name, the browser is cancelling the request, apparently due to a mal-formed location header in the redirect response from the server:

$ curl -I http://myhost/etcd/test/does_work
HTTP/1.1 302 Found
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Date: Mon, 19 Sep 2016 15:18:48 GMT
Pragma: no-cache
Cache-Control: no-cache, no-store
Location: http://myhost/etcd/test/does_work;jsessionid=19komblrx0muvjix1tgzp3cc6?0
(...)

$ curl -I http://myhost/etcd/test/doesnt:work
HTTP/1.1 302 Found
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Date: Mon, 19 Sep 2016 15:18:53 GMT
Pragma: no-cache
Cache-Control: no-cache, no-store
Location: doesnt:work;jsessionid=a41uqdoyk8ldu6c90ikwhs85?0

@luispollo
Copy link
Contributor Author

luispollo commented Sep 20, 2016

@nikfoundas I spent quite some time trying to debug this so I could contribute a fix, but unfortunately I'm not familiar with Wicket and so I'm stuck. Do you have any idea what could be causing this? I was unable to find why Wicket returns a 302 (redirect) in the first place, and in any case can't spot anything in the logs that would indicate errors anywhere. Please help.

luispollo added a commit to luispollo/etcd-viewer that referenced this issue Sep 21, 2016
Previous version of Wicket had issues handling URLs with colons, which broke viewing etcd keys with colons in their names.
nikfoundas added a commit that referenced this issue Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant