-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this doesn't support auth feature #2
Comments
Can you please provide some further details about your environment? |
./etcdctl -version Sure just being able to pass user:pasword to the call would work as right now there is no option to pass user credentials when auth is enabled. On a separate note, it would be great if we can do user/role management as we do key/value management today using this viewer. (Though it is great to pass this viewer to the prod admin for key/value maintenance - it makes it much more usable if the admins could manage users/roles as well. I'm thinking of looking into this myself, if time permits) |
@raoofmd Thank you very much for you feedback and ideas! |
@raoofmd After some studying and experiments I have managed to create a solution that is working, but I still have some open points to resolve and prepare a next release to upload.
Etcd server by default has a guest user and guest role and even if authentication is enabled initially you should be able to view and populate the registry without providing any credentials. If you delete the guest role then you start to get unauthorized exceptions. Can you please verify that this is your case? One last thing ... Have you tried to build the application from the source or are you using the docker based distribution? If you are comfortable using the source I could push some draft changes to the master to have an actual overview and provide some feedback without waiting the next release ... Looking forward for your response! |
@nikfoundas appreciate for putting the approach together. I would like to discuss the above points:
Absolutely, I revoked guest user. I'm using your source, successfully built it using maven3 and deployed on tomcat 7 and 8, jdk8 |
@raoofm My question regarding the use of the source code was to push some changes and have your feedback prior to releasing the modifications. Please check my latest commit on the master branch which adds support for authentication. One "quite big" change is that the etcd registry selection is now performed through the top level menu. The selected registry is not stored in the web session any more. So you can navigate multiple registries using different tabs on your browser. After some discussions with some collegues we decided that authentication information should NOT be erased when switching between registries. Only if you choose to sign out explicitely from some registry or the session expires after 5 minutes or you choose to sign out entirely. So authentication information is kept in the same session for many different etcd registries at the same time. Authentication information is provided on the top level menu on a form that is visible when the selected registry has authentication enabled and no credentials are yet provided. When you have signed in some registry the Sign out menu appears and you can sign out any user from any registry and sign in as another user. The registy selection panel on the navigation page is temporarity disabled because I haven't made up my mind where should I put the etcd cluster monitor and management of registries (add/remove etcd cluster). I would really appreciate your feedback and ideas! |
@raoofm I have pushed some more improvements and some bug fixes that were accidentally introduced during the implementation of the auth feature. Please check the latest commits on the master branch. |
@nikfoundas ya noticed that and started debugging those. Good that you have pushed the fixes, let me try that out. Thanks. |
@nikfoundas ping |
if auth feature is enable then etcd-viewer get unauthorized issue. There is no way to pass user:password for etcd
The text was updated successfully, but these errors were encountered: