Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example path for images needs updating #103

Open
AnthonyAndroulakis opened this issue Dec 11, 2024 · 1 comment · May be fixed by #80
Open

Example path for images needs updating #103

AnthonyAndroulakis opened this issue Dec 11, 2024 · 1 comment · May be fixed by #80

Comments

@AnthonyAndroulakis
Copy link
Contributor

I noticed the examples have the niivue image path listed as https://github.com/niivue/niivue/raw/main/demos/images/, which results in this not found error:
Screen Shot

changing the path to path = "https://github.com/niivue/niivue/raw/main/packages/niivue/demos/images/" fixes this.

@christian-oreilly
Copy link
Collaborator

Hey @AnthonyAndroulakis! Thanks for pointing this out! PR #80 which should merge soon will simplify the use of example datasets and should fix this issue at the same time. I'll flag this issue in that PR so that we make sure it does. We should also ensure the CI runs the example notebooks when commits are done on a PR so that any future changes that break notebooks get automatically flagged and fixed before merging!

@christian-oreilly christian-oreilly linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants