Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnsProvider -- make provider accessable for columns editing [Gutenberg collection processing backlog] #464

Open
nicolay-r opened this issue May 11, 2023 · 0 comments
Assignees
Labels
critical enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 11, 2023

Problem: It is not possible to modify columns outside the sampler. Let's say we would like to display sent_ind which is calculated during sampling, but not listed in the related ColumnsProvider by being a task-specific requirement

How to fix this: There is a need to bring the related initialization of the provider to the upper level:

def create_samples_repo(keep_labels, rows_provider, storage):
assert(isinstance(rows_provider, BaseRowProvider))
assert(isinstance(keep_labels, bool))
assert(isinstance(storage, BaseRowsStorage))
return BaseInputSamplesRepository(
columns_provider=SampleColumnsProvider(store_labels=keep_labels),
rows_provider=rows_provider,
storage=storage)

Tricky moment is to consider other dependencies, based on the presence of the label column depending on the DataType. I do beleive it might be restructured, so BertExperimentInputSerializerPipelineItem or others might have access to the ColumnsProvider

@nicolay-r nicolay-r added the enhancement New feature or request label May 11, 2023
@nicolay-r nicolay-r self-assigned this May 11, 2023
nicolay-r added a commit that referenced this issue May 11, 2023
@nicolay-r nicolay-r changed the title ColumnsProvider -- make provider acessable for columns editing [Gutenberg collection processing backlog] ColumnsProvider -- make provider accessable for columns editing [Gutenberg collection processing backlog] May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant