Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll completion callback #53

Open
gang-qiu opened this issue Dec 1, 2017 · 3 comments
Open

Scroll completion callback #53

gang-qiu opened this issue Dec 1, 2017 · 3 comments

Comments

@gang-qiu
Copy link

gang-qiu commented Dec 1, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

Current behavior

No way to execute a callback after scrolling has completed

Expected behavior

define a config parameter for a completion callback

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

I want to execute additional animations after the scrolling.

Environment


Angular version: X.Y.Z


Your version of `@nicky-lenaers/ngx-scroll-to`:


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@nicky-lenaers
Copy link
Owner

Hi @gang-qiu , thank you for your issue. This is certainly a good feature. I'm currently working on fixing some other issues. Please check back in a short while for this feature.

Thanks! 💯

@srtab
Copy link

srtab commented Aug 23, 2018

Hi @nicky-lenaers,
This feature would be a huge addition to the plugin. We are using it in production and our client just ask some extra behavior right after scroll ends and for now it's impossible to do it without this feature.
Do you have a prevision when you can make it available?
Thanks and congrats for the amazing plugin :)

@uncleGera
Copy link

Hi!
You can use third callback in Observable subscription like this

this.scrollToService
  .scrollTo({ target })
  .subscribe(null, null, () => console.log('Scroll completed!'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants