Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong for loop #102

Open
tufa-8 opened this issue Oct 17, 2018 · 0 comments
Open

Wrong for loop #102

tufa-8 opened this issue Oct 17, 2018 · 0 comments

Comments

@tufa-8
Copy link

tufa-8 commented Oct 17, 2018

for (let parent = nativeElement; parent = parent.parentElement; null) {

Don't know if this is intentional or not... Condition and increment statements are switched. As a result in the first iteration, the element is the parent and not the actual native element itself. As a result, the behavior is that it is always the container that is the target to scroll to, which is not desirable in all cases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants