Step Upgrade acme.sh: State is set to "changed" when acme.sh is already up to date

[fkonradmain]

The optional Step Upgrade acme.sh which runs acme.sh --upgrade in the background, produces the output

[Thu Jun 13 17:31:04 CEST 2024] Already uptodate!
[Thu Jun 13 17:31:04 CEST 2024] Upgrade success!

when acme.sh already was up to date when triggering the upgrade.

Yet line 54 in tasks/main.yml only queries if "Upgrade success!" was in stdout. If said string was in stdout, it sets changed to true.

My recommendation is, adding a condition that sets changed to false when Already uptodate! is in stdout.

For example this seems to work:

  changed_when:
    - upgrade_result.rc == 0
    - "Upgrade success" in upgrade_result.stdout
    - not("Already uptodate" in upgrade_result.stdout)

Link to the mentioned code: https://github.com/nickjj/ansible-acme-sh/blob/76c835e9f7dd387d1612ff8b4d58c4aaf2d812e1/tasks/main.yml#L54C3-L54C86