Make installing dalli and redis gem optional #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doits
force-pushed
the
optional_memcached_redis
branch
from
23f163d to
4a4fde6
Compare
doits
force-pushed
the
optional_memcached_redis
branch
from
4a4fde6 to
0675462
Compare
doits
force-pushed
the
optional_memcached_redis
branch
from
77b9693 to
21eb4d9
Compare
doits
force-pushed
the
optional_memcached_redis
branch
from
21eb4d9 to
1fa3a39
Compare
|
I think the PR is ready now. What do you think? If you merge and release this, it should be a bigger version change (maybe even 1.0.0??). |
|
@doits Thanks for this branch. It's been working great for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3 and removes a deprecation warning for Dalli >= 3.0.0
Basically it blows up when doing
Suo::Client::Memcached.neworSuo::Client::Redis.newwithout the respective gem and not passing in a custom client.I added the check for the custom client in case somebody uses a special client without the official
dalliorredisgem.