External nanomsg fixes #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building for NodeJS 20 Signed-off-by: Zoltán Böszörményi <[email protected]>
The pkg-config file name in nanomsg 0.9 was changed from libnanomsg.pc to nanomsg.pc. nanomsg 0.9 was released in May 2016. Signed-off-by: Zoltán Böszörményi <[email protected]>
nanomsg headers are installed in /usr/include/nanomsg but only ancient versions (0.8 and before) provided -I/usr/include/nanomsg in libnanomsg.pc, if ever. The embedded source is for 1.1.0, the previous commit stopped using libnanomsg.pc. Instead, pass -DSYSTEM_NANOMSG=1 to the compiler when using --use_system_libnanomsg=true and use conditional compiling to include headers from the correct location. Signed-off-by: Zoltán Böszörményi <[email protected]>
zboszor
force-pushed
the
external-nanomsg-fixes
branch
from
e4cb60f to
f43a1de
Compare
Signed-off-by: Zoltán Böszörményi <[email protected]>
This version also supports NodeJS 21 and 22. Signed-off-by: Zoltán Böszörményi <[email protected]>
Signed-off-by: Zoltán Böszörményi <[email protected]>
The solution was copied from "nan". Signed-off-by: Zoltán Böszörményi <[email protected]>
Signed-off-by: Zoltán Böszörményi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.