Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add an override for shadow #9

Open
Walheimat opened this issue Feb 20, 2024 · 1 comment
Open

Feature request: Add an override for shadow #9

Walheimat opened this issue Feb 20, 2024 · 1 comment

Comments

@Walheimat
Copy link

Hello. First of all: thanks for the theme, it's very nice.

One minor issue I have is that some of the standard faces aren't overridden, most notably shadow (see faces.el line 2411 and up in Emacs 29).

If you don't have time I could have a look as well. But I'm not sure how you feel about adding additional colors because at first glance none of the defined once would be a great match.

@nickav
Copy link
Owner

nickav commented Feb 20, 2024

thanks, glad you like it! maybe if there was one consistent shadow color to use for all shadows that could work?

i am not actively maintaining this but am happy to merge any PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants