-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created scrollTop feature #81
Open
tranthaison1231
wants to merge
10
commits into
nhim175:master
Choose a base branch
from
tranthaison1231:feater/scrollTop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
52f32af
Created scrollTop feater
tranthaison1231 4bcaf94
fix: feature/scrollTop
tranthaison1231 f6cf8f9
fix: feature/scrollTop
tranthaison1231 80be279
fix: feature/scrollTop
tranthaison1231 a37a18e
fix feature/scrollTop
tranthaison1231 3a37952
fix feature/scrollTop
tranthaison1231 affbf21
fix feature/scrollTop
tranthaison1231 31a2eab
feature/scrollTop
tranthaison1231 618ec6c
feature/scrollTop
tranthaison1231 866e133
feature/scrollTop
tranthaison1231 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,8 @@ | |
</a> | ||
</li> | ||
<li> | ||
<a href="https://www.youtube.com/watch?v=zIjRONNA_8Y&list=PLkY6Xj8Sg8-uPZnTdScfuH0xD-O6Kb-V-" target="_blank"> | ||
<a href="https://www.youtube.com/watch?v=zIjRONNA_8Y&list=PLkY6Xj8Sg8-uPZnTdScfuH0xD-O6Kb-V-" | ||
target="_blank"> | ||
<i class="socicon socicon-youtube icon icon--xs"></i> | ||
</a> | ||
</li> | ||
|
@@ -61,17 +62,35 @@ | |
</div> | ||
<!--end of row--> | ||
</div> | ||
<div id="scrollTop" class="scrollTop"> | ||
<img src="/images/up-arrow.svg" /> | ||
</div> | ||
<!--end of container--> | ||
</footer> | ||
|
||
<%- js('https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js') %> | ||
<%- js('https://cdnjs.cloudflare.com/ajax/libs/flickity/2.1.1/flickity.pkgd.min.js') %> | ||
<%- js('https://cdnjs.cloudflare.com/ajax/libs/smooth-scroll/14.2.1/smooth-scroll.min.js') %> | ||
<%- js('js/scripts.js') %> | ||
<script src="https://embed.small.chat/TAKF2JHMFGAY8GG7K5.js" async></script> | ||
|
||
<script> | ||
var scroll = new SmoothScroll('a[href*="#"]'); | ||
var scrollTopEl = document.querySelector("#scrollTop"); | ||
scrollTopEl.addEventListener("click", () => { | ||
document.body.scrollTop = 0; | ||
document.documentElement.scrollTop = 0; | ||
}); | ||
window.onscroll = onScroll; | ||
function onScroll() { | ||
if ( | ||
document.body.scrollTop > 30 || | ||
document.documentElement.scrollTop > 30 | ||
) { | ||
scrollTopEl.classList.add("showScroll"); | ||
} else { | ||
scrollTopEl.classList.remove("showScroll"); | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. để performance tốt hơn thì nên sử dụng debounce hoặc throttle để giảm số lần hàm |
||
</script> | ||
|
||
<!-- <footer id="footer"> | ||
|
@@ -84,4 +103,4 @@ | |
<%= __('powered_by') %> <a href="http://hexo.io/" target="_blank">Hexo</a> | ||
</div> | ||
</div> | ||
</footer> --> | ||
</footer> --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tranthaison1231 hiện tại mình đang dùng thư viện này để làm smooth scroll https://github.com/cferdinandi/smooth-scroll
Em học cách dùng rồi áp dụng