Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting of symptoms list does not remove current diagnosis #4

Open
ngkaiwen123 opened this issue Apr 14, 2023 · 1 comment
Open

Comments

@ngkaiwen123
Copy link
Owner

ngkaiwen123 commented Apr 14, 2023

Created a new diagnosis from the following symptoms, which resulted in diagnosis of "Fever" and "Sore Throat".

image.png

However, after resetting the symptoms, diagnosis history does not update accordingly. It is unsure whether the diagnosis history and symptom history is supposed to work together for output. This may also confuse users as to why there is still diagnosis for the day, when the symptoms are already reset.

image.png

@soc-pe-bot
Copy link

soc-pe-bot commented Apr 18, 2023

Team's Response

The underlying cause is the same as the duplicate issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

"View Diagnosis History" is confusing to use.

When symptoms are updated, it seems that past diagnosis and present diagnosis are mixed together. This makes it difficult to track what is the latest diagnosis of the patient.

Screenshot (459).png

After the first input of symptoms, the diagnosis is that I have a "fever, stomachache and and food posioning".
This is correctly shown in the view diagnosis history, shown below.

image.png

However, after deletion of a symptom, say "fever", my new diagnosis is simply "Stomach Ache" (Below)

Screenshot (462).png

When I went back to check the "View Diagnosis History" again, there is no new diagnosis shown. It is unsure whether the diagnosis of "Stomach Ache" is mixed within the first diagnosis history, or is it not created? Is it also possibly a functionality bug?

Shown below is after diagnosis of "stomachache".

image.png


[original: nus-cs2113-AY2223S2/pe-interim#890] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

After deleting some symptoms, we believe that updating your current diagnosis is sufficient for a patient, without needing to update your past diagnoses. Therefore, if your current diagnosis is not included in your diagnosis history for that day, it will be added in; if it is already present, it will be ignored. This is not a feature flaw, but rather, an intended design of the feature, since the diagnosis history is supposed to reflect all diagnoses the patient received, which should include any past diagnoses received. Hence this is out of scope.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: This bug is about the resetting of symptoms, rather than about the diagnosis history. Resetting symptoms should have cleared the diagnosis history. If the group intends to save the past diagnosis, there should be an option to "make a new diagnosis", or else it may confuse the user as to why they are still diagnosed with illnesses despite clearing their symptoms from the symptom list.


❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: Screenshot (526).png

Using the definition of "severity level" as shown by the screenshot above, this feature flaw causes much inconveinience to the user, which should have remained at severity.Medium.

Diagnosis history is presented in a confusing manner that users have a difficult time figuring out which is their latest diagnosis. This is not just a "minor inconvenience", but a rather frequent one.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants