-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path style breaks fetching INDEX_PAGE #210
Comments
Thank you for the report @HighOnMikey , I'm a new maintainer on this project so let me take some time to understand that specific area more deeply and reply. |
Hi @HighOnMikey thank you for your patience.
I think that's the shared understanding we need. Testing the code I didn't see any indication that it's not doing that but I could be missing a key part of your report so just wanting to be sure. Here are some logs from my local testing requesting
I think I see the error here, when we redirect to Is this the bug you're referring to or have I found a different bug? 😓 |
First of all, sorry for the delayed response!
Correct. The core functionality of path style requests works as intended. The bug is limited to attempting to find an index page when
Yes, this is directly related to the bug. The |
Thanks for confirming and for your patience. I'm going to try to put together a fix in the coming days. I'll tag you for a test/review when it's up. |
Hey @HighOnMikey sorry again for the slowness on this. Can you take a look at #230 and see if it solves your issue? Let me know if you need a container image built for you to test. |
Hello @4141done, is there a reason this MR is not merged yet? I confirm that the latest image (latest-20241216) still have the same issue if however if we have Note: I am using path style |
loadContent
will always attempt fetching theINDEX_PAGE
by building the URI path usings3uri()
.When using
S3_STYLE = 'path'
, this will prepend the URI path with the S3 bucket. However, the fetch is made against nginx itself, meaning the URI path will always be incorrect for the requested index.To Reproduce
Set the following variables:
Expected behavior
Incorrect URI currently being built:
http://127.0.0.1/<bucket_name>/<request_path>/<INDEX_PAGE>
Expected URI:
http://127.0.0.1/<request_path>/<INDEX_PAGE>
Environments Tested
master
@c687663
ghcr.io/nginxinc/nginx-s3-gateway/nginx-oss-s3-gateway:latest
Workaround
I would submit a PR but I'm not sure which direction would be preferred by the project to go about building the URI path. However, here's a quick fix to demonstrate the issue:
From
To
The text was updated successfully, but these errors were encountered: