Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression when updating from 3.2 to 3.11 #1067

Open
FrancescoBorzi opened this issue Apr 20, 2023 · 0 comments
Open

Regression when updating from 3.2 to 3.11 #1067

FrancescoBorzi opened this issue Apr 20, 2023 · 0 comments

Comments

@FrancescoBorzi
Copy link

FrancescoBorzi commented Apr 20, 2023

I'm trying to update my ng-apimock from version 3.2 to the latest (currently 3.11 and I found an annoying regression.

I'm using the Advanced request matchin by specifying a "body" for my requests so I could differenciate different scenarios, for example in my mock definition:

     // MOCK DEFINITION
     "body": {
      "someParam": "SOME_VALUE"
    }

This used to work for all requests having someParam with SOME_VALUE as well as other parameters too.
In other words, this matched with requests such as:

    // Request match: ok with version 3.2, not ok with version 3.11 because of the extra "someOtherParam"
    "body": {
      "someParam": "SOME_VALUE",
      "someOtherParam": "it did not matter what value is here or weather this is even there or not"
    }

so it matched ALL requests having "someParam": "SOME_VALUE",` no matter if there were other params or not.

After upgrading from 3.2 to version 3.11 (I don't know which exact version it introduced this regression) it ONLY matches requests that have ONLY "someParam": "SOME_VALUE", and it does not match if additional params are specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant