Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split this module #12

Open
nfroidure opened this issue Mar 29, 2014 · 8 comments
Open

Split this module #12

nfroidure opened this issue Mar 29, 2014 · 8 comments

Comments

@nfroidure
Copy link
Owner

It does to many different things.

@nfroidure
Copy link
Owner Author

Maybe a shape to path module
A SVGTransform module
And a SVG to Path module ?

@nfroidure
Copy link
Owner Author

Moved forward by externalizing. Would reuse a tested open source module who borrowed/improved/replaced that code. ;)

@breezewish
Copy link

+1. really need its svgtransform part

@nfroidure
Copy link
Owner Author

@breeswish you mean those? https://github.com/nfroidure/svgicons2svgfont/blob/master/src/svgshapes2svgpath.js

Otherwise Pathdata tranformations are mainly handled here: https://github.com/nfroidure/SVGPathData

@nfroidure
Copy link
Owner Author

The shape part will be added there nfroidure/svg-pathdata#25

@y-nk
Copy link

y-nk commented Sep 28, 2018

i jump on this to also ask to separate the stream implementation from the content itself. what if we already have svg content in memory ?

@nfroidure
Copy link
Owner Author

@y-nk you should be able to just svgIconsTostream.write(new PassThrough().end(mySVGIconBuffer)) or something like that..

@y-nk
Copy link

y-nk commented Oct 23, 2018

that sounds very unnatural to me, but thanks for the reply ; i'll do as proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants