Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate data type consistency across files #31

Open
tanho63 opened this issue Aug 12, 2021 · 2 comments
Open

Investigate data type consistency across files #31

tanho63 opened this issue Aug 12, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@tanho63
Copy link
Member

tanho63 commented Aug 12, 2021

Where should this responsibility live?

  • at the nflreadr level? (nflreadr coerces types)
  • at the file maintainer level?

Seems to be best at the file maintainer level so that type is set once and not when the user runs it...but that means we need to come up with an nflverse-level type dictionary

Relatedly: column naming (player? player_name? full_player_name? name? merge_name) etc

@tanho63 tanho63 added the enhancement New feature or request label Oct 18, 2021
@alecglen
Copy link

alecglen commented Aug 4, 2023

Hey @tanho63, interested in whether you've given this further thought recently?

I ran into the column-naming inconvenience a bunch this week while making some updates to nfl_data_py, and I'm considering transforming them all within the module to standardize the outputs. But on the other hand, I value keeping the API close to nflreadr for the sake of inter-communication between R/Python users in the Discord.

@tanho63
Copy link
Member Author

tanho63 commented Aug 4, 2023

column naming or data types? column naming is difficult because we'd need to either support backcompat or do some sort of warn/deprecation process which wouldn't be fast.

I'd broadly be in favour of at least determining a standardized naming scheme that we could move towards in the future, if you have something to propose there. Would likely belong in a new issue since this specific one is about ensuring consistency of doubles, ints, character etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants