Missing PFR IDs in nflreadR for the 2024 Rookie Class

[marvin3FF]

Is there an existing issue for this?

• I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

• I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

4.6.1.9013

Describe the bug

When pulling weekly roster data out of nflreadR, rookies are currently missing their pfr_ids.

After chatting with John in the discord channel, he mentioned that nflreadr::load_ff_playerids() is the source of the ids and is currently missing data for rookies.

Reprex

nflreadr::load_rosters_weekly(2024:2024)
nflreadr::load_ff_playerids()

Expected Behavior

When loading weekly roster data, rookies should have their pfr_ids included in the dataset.

nflverse_sitrep

── System Info ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.2 (2023-10-31) • Running under: macOS Sonoma 14.6.1
── Package Status ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   package  installed  cran        dev behind
1   nfl4th 1.0.4.9002 1.0.4 1.0.4.9002       
2 nflfastR 4.6.1.9013 4.6.1 4.6.1.9013       
3 nflplotR      1.4.0 1.4.0      1.4.0       
4 nflreadr   1.4.1.02 1.4.1   1.4.1.02       
5 nflseedR 1.2.0.9001 1.2.0 1.2.0.9001       
6 nflverse      1.0.3 1.0.3      1.0.3       
── Package Options ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass     (1.2.0)   • gt          (0.11.0)   • purrr        (1.0.2)    
• backports   (1.5.0)   • gtable      (0.3.5)    • R6           (2.5.1)    
• base64enc   (0.1-3)   • highr       (0.11)     • rappdirs     (0.3.3)    
• bigD        (0.2.0)   • hms         (1.1.3)    • RColorBrewer (1.1-3)    
• bitops      (1.0-8)   • htmltools   (0.5.8.1)  • Rcpp         (1.0.13)   
• bslib       (0.8.0)   • htmlwidgets (1.6.4)    • reactable    (0.4.4)    
• cachem      (1.1.0)   • httr        (1.4.7)    • reactR       (0.5.0)    
• cli         (3.6.3)   • isoband     (0.2.7)    • rlang        (1.1.4)    
• codetools   (0.2-20)  • janitor     (2.2.0)    • rmarkdown    (2.28)     
• colorspace  (2.1-1)   • jquerylib   (0.1.4)    • rstudioapi   (0.16.0)   
• commonmark  (1.9.1)   • jsonlite    (1.8.8)    • sass         (0.4.9)    
• compiler    (4.3.2)   • juicyjuice  (0.1.0)    • scales       (1.3.0)    
• cpp11       (0.4.7)   • knitr       (1.48)     • snakecase    (0.11.1)   
• crayon      (1.5.3)   • labeling    (0.4.3)    • splines      (4.3.2)    
• curl        (5.2.2)   • lattice     (0.22-6)   • stats        (4.3.2)    
• data.table  (1.16.0)  • lifecycle   (1.0.4)    • stringi      (1.8.4)    
• digest      (0.6.37)  • listenv     (0.9.1)    • stringr      (1.5.1)    
• dplyr       (1.1.4)   • lubridate   (1.9.3)    • sys          (3.4.2)    
• evaluate    (0.24.0)  • magick      (2.8.4)    • tibble       (3.2.1)    
• fansi       (1.0.6)   • magrittr    (2.0.3)    • tidyr        (1.3.1)    
• farver      (2.1.2)   • markdown    (1.13)     • tidyselect   (1.2.1)    
• fastmap     (1.2.0)   • MASS        (7.3-60)   • timechange   (0.3.0)    
• fastrmodels (1.0.2)   • Matrix      (1.6-1.1)  • tinytex      (0.52)     
• fontawesome (0.5.2)   • memoise     (2.0.1)    • tools        (4.3.2)    
• fs          (1.6.4)   • methods     (4.3.2)    • utf8         (1.2.4)    
• furrr       (0.3.1)   • mgcv        (1.9-1)    • utils        (4.3.2)    
• future      (1.34.0)  • mime        (0.12)     • V8           (5.0.0)    
• generics    (0.1.3)   • munsell     (0.5.1)    • vctrs        (0.6.5)    
• ggpath      (1.0.2)   • nlme        (3.1-166)  • viridisLite  (0.4.2)    
• ggplot2     (3.5.1)   • openssl     (2.2.1)    • withr        (3.0.1)    
• globals     (0.16.3)  • parallel    (4.3.2)    • xfun         (0.47)     
• glue        (1.7.0)   • parallelly  (1.38.0)   • xgboost      (1.7.8.1)  
• graphics    (4.3.2)   • pillar      (1.9.0)    • xml2         (1.3.6)    
• grDevices   (4.3.2)   • pkgconfig   (2.0.3)    • yaml         (2.3.10)   
• grid        (4.3.2)   • progressr   (0.14.0)     
• gsubfn      (0.7)     • proto       (1.0.0)

Screenshots

No response

Additional context

No response

[marvin3FF]

@tanho63 @john-b-edwards Sorry to bother. Wondering if you know when this might be fixed. Thank you!

[tanho63]

I think Seb is working on overhauling load_players() in the next few weeks. In the meantime I think I managed to push a limited selection of names to load_ff_playerids() just now after a small fix

[mrcaseb]

Implemented in https://github.com/nflverse/nflverse-players

The dataset currently is located in the players_components release and nflreadr will load it through load_players in the next offseason.