Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clean_player_names.csv #247

Closed
wants to merge 1 commit into from
Closed

Update clean_player_names.csv #247

wants to merge 1 commit into from

Conversation

TheMathNinja
Copy link
Contributor

Added Hollywood Brown entry

@TheMathNinja
Update clean_player_names.csv
8d96d3a 
Added Hollywood Brown entry
@TheMathNinja
Copy link
Contributor Author

Hope I did it ok.

tanho63
tanho63 reviewed Aug 21, 2024
View reviewed changes
data-raw/clean_player_names.csv
Tank Dell,Nathaniel Dell
Hollywood Brown,Marquise Brown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reverse of what we want, correct name goes first and alternative name comes second

@tanho63
Copy link
Member

tanho63 commented Aug 21, 2024

Also need to do the second part of the requested steps: #246 (comment)

@tanho63 tanho63 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanho63 tanho63 tanho63 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMathNinja @tanho63