Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing data for defensive snap counts #230

Open
2 tasks done
engineerchange opened this issue Nov 28, 2023 · 0 comments
Open
2 tasks done

[BUG] Missing data for defensive snap counts #230

engineerchange opened this issue Nov 28, 2023 · 0 comments

Comments

@engineerchange
Copy link

engineerchange commented Nov 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

1.4.0.5

Describe the bug

Jack Jones (pfr_id=='JoneJa10') is missing some snap counts from middle of the season.

Confirming with PFR's website, he should have defensive snaps weeks 7-12 of the 2023-24 season, but he only has data points for weeks 11-12.
image

I found similar issue for the following players and weeks:
Tariq Woolen (WoolTa00), week 1

image

Timmy Horne (HornTi00), week 3

image

Both players above had tackles reported, but no defensive snaps via load_snap_counts(); however PFR's website does show they had defensive snap counts.

Reprex

Jack Jones

r
nflreadr::load_snap_counts() |> dplyr::filter(pfr_player_id == 'JoneJa10')
#> ── nflverse snap counts ────────────────────────────────────────────────────────
#> ℹ Data updated: 2023-11-28 07:32:27 EST
#> # A tibble: 2 × 16
#>   game_id pfr_game_id season game_type  week player pfr_player_id position team 
#>   <chr>   <chr>        <int> <chr>     <int> <chr>  <chr>         <chr>    <chr>
#> 1 2023_1… 202311190m…   2023 REG          11 Jack … JoneJa10      CB       LV   
#> 2 2023_1… 202311260r…   2023 REG          12 Jack … JoneJa10      CB       LV   
#> # ℹ 7 more variables: opponent <chr>, offense_snaps <dbl>, offense_pct <dbl>,
#> #   defense_snaps <dbl>, defense_pct <dbl>, st_snaps <dbl>, st_pct <dbl>

Created on 2023-11-28 with reprex v2.0.2

Timmy Horne

nflreadr::load_snap_counts() |> dplyr::filter(pfr_player_id == 'HornTi00')
#> ── nflverse snap counts ────────────────────────────────────────────────────────
#> ℹ Data updated: 2023-11-28 07:32:27 EST
#> # A tibble: 2 × 16
#>   game_id pfr_game_id season game_type  week player pfr_player_id position team 
#>   <chr>   <chr>        <int> <chr>     <int> <chr>  <chr>         <chr>    <chr>
#> 1 2023_0… 202310010j…   2023 REG           4 Timmy… HornTi00      DT       ATL  
#> 2 2023_1… 202311120c…   2023 REG          10 Timmy… HornTi00      DT       ATL  
#> # ℹ 7 more variables: opponent <chr>, offense_snaps <dbl>, offense_pct <dbl>,
#> #   defense_snaps <dbl>, defense_pct <dbl>, st_snaps <dbl>, st_pct <dbl>

Created on 2023-11-28 with reprex v2.0.2

Riq Woolen

nflreadr::load_snap_counts() |> dplyr::filter(pfr_player_id == 'WoolTa00')
#> ── nflverse snap counts ────────────────────────────────────────────────────────
#> ℹ Data updated: 2023-11-28 07:32:27 EST
#> # A tibble: 9 × 16
#>   game_id pfr_game_id season game_type  week player pfr_player_id position team 
#>   <chr>   <chr>        <int> <chr>     <int> <chr>  <chr>         <chr>    <chr>
#> 1 2023_0… 202309170d…   2023 REG           2 Riq W… WoolTa00      CB       SEA  
#> 2 2023_0… 202310020n…   2023 REG           4 Riq W… WoolTa00      CB       SEA  
#> 3 2023_0… 202310150c…   2023 REG           6 Riq W… WoolTa00      CB       SEA  
#> 4 2023_0… 202310220s…   2023 REG           7 Riq W… WoolTa00      CB       SEA  
#> 5 2023_0… 202310290s…   2023 REG           8 Riq W… WoolTa00      CB       SEA  
#> 6 2023_0… 202311050r…   2023 REG           9 Riq W… WoolTa00      CB       SEA  
#> 7 2023_1… 202311120s…   2023 REG          10 Riq W… WoolTa00      CB       SEA  
#> 8 2023_1… 202311190r…   2023 REG          11 Riq W… WoolTa00      CB       SEA  
#> 9 2023_1… 202311230s…   2023 REG          12 Riq W… WoolTa00      CB       SEA  
#> # ℹ 7 more variables: opponent <chr>, offense_snaps <dbl>, offense_pct <dbl>,
#> #   defense_snaps <dbl>, defense_pct <dbl>, st_snaps <dbl>, st_pct <dbl>

Created on 2023-11-28 with reprex v2.0.2

Expected Behavior

All the relevant data to be reported as on PFR's site.

nflverse_sitrep

── System Info ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.0 (2023-04-21) • Running under: macOS Monterey 12.7.1
── Package Status ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   package installed  cran        dev behind
1   nfl4th     1.0.4 1.0.4 1.0.4.9001    dev
2 nflfastR     4.6.0 4.6.0 4.6.0.9000    dev
3 nflplotR     1.2.0 1.2.0 1.2.0.9003    dev
4 nflreadr  1.4.0.05 1.4.0   1.4.0.09    dev
5 nflseedR     1.2.0 1.2.0      1.2.0       
6 nflverse     1.0.3 1.0.3      1.0.3       
── Package Options ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass     (1.2.0)   • gsubfn     (0.7)      • progressr    (0.14.0)   
• backports   (1.4.1)   • gtable     (0.3.4)    • proto        (1.0.0)    
• cachem      (1.0.8)   • hms        (1.1.3)    • purrr        (1.0.2)    
• cli         (3.6.1)   • httr       (1.4.7)    • R6           (2.5.1)    
• codetools   (0.2-19)  • isoband    (0.2.7)    • rappdirs     (0.3.3)    
• colorspace  (2.1-0)   • janitor    (2.2.0)    • RColorBrewer (1.1-3)    
• compiler    (4.3.0)   • jsonlite   (1.8.7)    • Rcpp         (1.0.11)   
• cpp11       (0.4.6)   • labeling   (0.4.3)    • rlang        (1.1.2)    
• crayon      (1.5.2)   • lattice    (0.22-5)   • rstudioapi   (0.15.0)   
• curl        (5.1.0)   • lifecycle  (1.0.4)    • scales       (1.2.1)    
• data.table  (1.14.8)  • listenv    (0.9.0)    • snakecase    (0.11.1)   
• digest      (0.6.33)  • lubridate  (1.9.3)    • splines      (4.3.0)    
• dplyr       (1.1.3)   • magick     (2.8.1)    • stats        (4.3.0)    
• fansi       (1.0.5)   • magrittr   (2.0.3)    • stringi      (1.7.12)   
• farver      (2.1.1)   • MASS       (7.3-60)   • stringr      (1.5.0)    
• fastmap     (1.1.1)   • Matrix     (1.6-2)    • sys          (3.4.2)    
• fastrmodels (1.0.2)   • memoise    (2.0.1)    • tibble       (3.2.1)    
• furrr       (0.3.1)   • methods    (4.3.0)    • tidyr        (1.3.0)    
• future      (1.33.0)  • mgcv       (1.9-0)    • tidyselect   (1.2.0)    
• generics    (0.1.3)   • mime       (0.12)     • timechange   (0.2.0)    
• ggpath      (1.0.1)   • munsell    (0.5.0)    • tools        (4.3.0)    
• ggplot2     (3.4.4)   • nlme       (3.1-163)  • utf8         (1.2.4)    
• globals     (0.16.2)  • openssl    (2.1.1)    • utils        (4.3.0)    
• glue        (1.6.2)   • parallel   (4.3.0)    • vctrs        (0.6.4)    
• graphics    (4.3.0)   • parallelly (1.36.0)   • viridisLite  (0.4.2)    
• grDevices   (4.3.0)   • pillar     (1.9.0)    • withr        (2.5.2)    
• grid        (4.3.0)   • pkgconfig  (2.0.3)    • xgboost      (1.7.5.1)

Screenshots

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant