Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTN data dictionary improvements #216

Open
1 of 4 tasks
tanho63 opened this issue Sep 6, 2023 · 3 comments
Open
1 of 4 tasks

FTN data dictionary improvements #216

tanho63 opened this issue Sep 6, 2023 · 3 comments

Comments

@tanho63
Copy link
Member

tanho63 commented Sep 6, 2023

  • read_thrown definitions: 1, 2, CHK check down, SD scramble drill, DES designed play (read 0, eg screens)
  • n_blitzers, n_pass_rushers
  • n_defense_box

Also:

  • add trimws() to FTN and rebuild
@mrcaseb
Copy link
Member

mrcaseb commented Aug 25, 2024

add trimws() to FTN and rebuild

Has this been implemented? Or is it actually necessary? I don't see any difference

p <- nflreadr::load_ftn_charting(TRUE)

c <- p |> dplyr::select(tidyselect::where(is.character))

s <- c |> dplyr::mutate_all(trimws)

waldo::compare(c, s)
#> ✔ No differences

Created on 2024-08-25 with reprex v2.1.1

@tanho63
Copy link
Member Author

tanho63 commented Aug 25, 2024

add trimws() to FTN and rebuild

Has this been implemented? Or is it actually necessary? I don't see any difference

p <- nflreadr::load_ftn_charting(TRUE)

c <- p |> dplyr::select(tidyselect::where(is.character))

s <- c |> dplyr::mutate_all(trimws)

waldo::compare(c, s)
#> ✔ No differences

Created on 2024-08-25 with reprex v2.1.1

Not that I can tell, so yeah can skip

@mrcaseb
Copy link
Member

mrcaseb commented Aug 25, 2024

Maybe ftn fixed on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants