Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle new schema structure in nf-core pipelines create-params-file #3276

Merged
merged 4 commits into from
Nov 12, 2024
Merged

handle new schema structure in nf-core pipelines create-params-file #3276

merged 4 commits into from
Nov 12, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 11, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.84%. Comparing base (27659c5) to head (e57a096).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/params_file.py 72.00% 7 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mashehu mashehu merged commit 24e2dc2 into nf-core:dev Nov 12, 2024
84 checks passed
@mashehu mashehu deleted the fix-create-params branch November 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot