Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 Add new command nf-core rocrate to create a Research Object (RO) crate for a pipeline (continuation from #2680) [skip changelog] #3240

Merged
merged 17 commits into from
Nov 28, 2024
Merged

📦 Add new command nf-core rocrate to create a Research Object (RO) crate for a pipeline (continuation from #2680) [skip changelog] #3240

merged 17 commits into from
Nov 28, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 23, 2024

#2680 was auto-merged too fast. Continuing the work with this PR

@mashehu mashehu mentioned this pull request Oct 23, 2024
Merged
@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

@nf-core-bot update snapshots

@ewels ewels added this to the 3.1 milestone Nov 21, 2024
@ewels ewels changed the title Add new command nf-core rocrate to create a Research Object (RO) crate for a pipeline (continuation from #2680) [skip changelog] 📦 Add new command nf-core rocrate to create a Research Object (RO) crate for a pipeline (continuation from #2680) [skip changelog] Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.63063% with 43 lines in your changes missing coverage. Please review.

Project coverage is 75.72%. Comparing base (ba332b6) to head (43287c6).
Report is 18 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/rocrate.py 86.26% 25 Missing ⚠️
nf_core/commands_pipelines.py 11.76% 15 Missing ⚠️
nf_core/__main__.py 87.50% 1 Missing ⚠️
nf_core/modules/modules_json.py 50.00% 1 Missing ⚠️
nf_core/pipelines/lint/files_exist.py 83.33% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

nf_core/pipelines/create/template_features.yml Show resolved Hide resolved
@mashehu mashehu merged commit 7284262 into nf-core:dev Nov 28, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @ewels