move X sent from Bob to Alice from step 2 to step 4b #37
Conversation
|
|
||
| - in step 4 b) Bob's device adds group X to the encrypted part of the | ||
| 'vc-request-with-auth' message, together with ``Bob_FP`` and the ``AUTH`` | ||
| value from step 1. |
There was a problem hiding this comment.
Could bob try to join a different group than the one he was invited for?
There was a problem hiding this comment.
I think, this depends on the implementation. In Delta, X is groupName+random64bitNumber, so i do not think this is possible. If, in other implementations, X are small, continuously increasing numbers, Alice could check if X matches the generated INVITENUMBER.
However, this seems to be independent from this change - if we would add X to step 2 (vg-request) - Alice has to do the same in step 3 then - and has even to fear that X could be modified by MitM.
There was a problem hiding this comment.
ah, so there is a "human readable" group name and a (random) group code -- i guess the group name can change but the group code will stay, right?
|
isn't it funny how the PR only changes a few lines but the discussion spans pages already? :) |
r10s
changed the title
see #33 from comments and reasons