Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict QR code to single use for verfication #62

Closed
azul opened this issue Jul 17, 2018 · 2 comments
Closed

Restrict QR code to single use for verfication #62

azul opened this issue Jul 17, 2018 · 2 comments

Comments

@azul
Copy link
Member

azul commented Jul 17, 2018

Michael Rogers lists a few attack scenarios if qr codes can be reused. They are mainly based on the attacker being able to access the QR code and performing the verified contact workflow.

Allowing AUTH codes to be used only once mitigates this attack because we can warn the person who showed the invite code that there were two attempts to use it.

(This issue is part of the feedback on the messaging@moderncrypto mailing list #61)

@azul
Copy link
Member Author

azul commented Jul 18, 2018

One problem i see with this solution is DOS attacks and reacting to connection attempts after a (seemingly) successful verification. In particular.. an observer of the mail exchange could resend Bobs 'vc-request-with-auth' message from a different email address. My understanding is that this would look like a second legitimate contact request which would lead to a warning and error case. It would not allow reading encrypted messages - but it would cause doubt on the legitimate verification attempt.

@azul
Copy link
Member Author

azul commented Aug 27, 2018

With #66 Alice will only perform the check in step 5 where she also received the AUTH token. Therefore she can easily destinguish legitimate QR code scans from replay attacks. If an attacker attempts a replay from a different email address the error message would mention this email address rather than Bobs.

@azul azul closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant