Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of checking when Bob knows Alice's FP #44

Closed
carmelatroncoso opened this issue May 9, 2018 · 3 comments · Fixed by #74
Closed

lack of checking when Bob knows Alice's FP #44

carmelatroncoso opened this issue May 9, 2018 · 3 comments · Fixed by #74

Comments

@carmelatroncoso
Copy link
Collaborator

a) If Bob's device knows a key that matches Alice_FP the protocol continues with 4b)

In step 4b) Bob just sends back his key, but he does not check that the email received is the same as the one he had associated to the value Alice_FP he had stored. Doesn't this open the door to an attack? As long as I know Alice's FP I can get Bob to engage. Am I missing something?

@azul
Copy link
Member

azul commented Oct 18, 2018

Just trying to understand by rephrasing here:
In 2.a) Bob just received a bootstrap code. Currently this happens via a QR code scan but later on there might be other mechanisms.
So now the person who send the bootstrap code could have send a combination of a FP bob knows and a wrong email address. So say Egon used his own FP but send Alices email address instead.
Bob's device will pick Egons key for Alices address.
If Egon also is in a MITM position or collaborating with an attacker who is they can complete the handshake.
The only way for Bob to notice would be that in the End his device displays... "Secure contact with Alice established". But he has been talking to Egon.

@hpk42
Copy link
Collaborator

hpk42 commented Oct 18, 2018

to fix this issue isn't it sufficient to write:

"a) If bob's device already verified that Alice's e-mail address is associated with Alice_FP the protocol continus with 4b)"

hpk42 added a commit that referenced this issue Oct 18, 2018
@hpk42 hpk42 mentioned this issue Oct 18, 2018
@azul
Copy link
Member

azul commented Oct 18, 2018

The approach sounds good. I would use a different term than 'verified'.
I think the main usecase here is verifying a contact i already have an autocrypt key for.

The other question for me is if we want to explicitely ask the user to verify that the email address matches the person they are talking to. I think we don't neet to but should make it very obvious who one is verifying by highlighting the email address during the process.

@azul azul closed this as completed in #74 Oct 19, 2018
azul added a commit that referenced this issue Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants