Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test to check download is valid #19

Open
ewels opened this issue Jun 10, 2023 · 3 comments
Open

CI test to check download is valid #19

ewels opened this issue Jun 10, 2023 · 3 comments

Comments

@ewels
Copy link
Member

ewels commented Jun 10, 2023

It would be great to have a CI check to confirm that the new download URL is valid and the sha is correct.

  • Check out code before and after proposed merge, parse both JSON trees and find any download URLs / shas that are new or changed
  • Try to download them and check the sha
@pditommaso
Copy link
Member

pditommaso commented Jun 12, 2023

Excellent point. It should also try to use it using this command:

export NXF_PLUGINS_TEST_REPOSITORY=<Plugins JSON URL>
nextflow run hello -plugins declared-plugin@declared-version 

@ewels
Copy link
Member Author

ewels commented Jun 12, 2023

Where the JSON URL is the public URL (not local file) of the modified JSON on the PR?

So for #17 it would be this?

export NXF_PLUGINS_TEST_REPOSITORY=https://raw.githubusercontent.com/nvnieuwk/plugins/a0fac2692cf4aef29158ccf3cbadd92c3e2cf463/plugins.json
nextflow run hello -plugins [email protected]

@pditommaso
Copy link
Member

Yes exactlty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants